-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow POST requests without body / content-type header #6881
Conversation
This is not possible for most routes as request will fail schema validation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6881 +/- ##
============================================
- Coverage 62.76% 62.75% -0.01%
============================================
Files 578 578
Lines 61273 61280 +7
Branches 2115 2113 -2
============================================
+ Hits 38456 38458 +2
- Misses 22779 22784 +5
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in v1.20.0 🎉 |
Motivation
Noticed the request validation is too strict for some routes, e.g.
getAttestationsRewards
allows that the request body can be omitted as per spec.apis/beacon/rewards/attestations.yaml#L15-L17
We don't allow this right now as we enforce that the content-type header is set if it's a POST request with a defined body schema but I think we can make it more lax. If both the content-type header and the body is omitted, we can just default to json parser as body parsing it not relevant, and other params such as headers, query, etc. are parsed the same way in the json vs. ssz parser.
For most routes, this request will fail before the handler is even called as schema validation enforces body to be an object.
Description
Allow POST requests without body / content-type header
E.g. the request below should be allowed without passing
-H "content-type: application/json" -d "[]"